Hi Ian > On 6 Oct 2021, at 12:07 pm, Ian Jackson <[email protected]> wrote: > > Rahul Singh writes ("Re: [PATCH v4 13/14] arm/libxl: Emulated PCI device tree > node in libxl"): >> libxl_defbool_val(libxl_defbool db) is implemented in such a way that it >> will assert >> if db value is the default. Therefore we have to explicitly set it to >> LIBXL__DEFBOOL_FALSE for x86. >> >> There are two option either we can have #ifdef or we can move the >> libxl_defbool_setdefault(&b_info->arch_arm.vpci, false) to common code. > > What is wrong with putting it in > libxl__arch_domain_build_info_setdefault > which I think exists precisely for this kind of thing ?
As we have to set the arch_arm.vpci to false for x86 and ARM I thought it is right to move the code to common code to avoid duplication. Are you suggesting to put " libxl_defbool_setdefault(&b_info->arch_arm.vpci, false)”in libxl__arch_domain_build_info_setdefault() for x86 and ARM differently. Regards, Rahul > > Ian.
