On Thu, Oct 07, 2021 at 04:17:28PM +0200, Jan Beulich wrote: > On 24.08.2021 12:50, Anthony PERARD wrote: > > --- a/tools/include/Makefile > > +++ b/tools/include/Makefile > > @@ -30,7 +30,7 @@ xen-dir: > > ln -s $(XEN_ROOT)/xen/include/acpi/platform acpi/ > > ln -s $(XEN_ROOT)/xen/include/acpi/ac*.h acpi/ > > ifeq ($(CONFIG_X86),y) > > - ln -s $(XEN_ROOT)/xen/include/asm-x86 xen/asm > > + ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/asm > > I think this would now better be > > ln -s $(XEN_ROOT)/xen/arch/x86/include/asm xen/ > > matching what is visible in context.
I'll change it. > > --- a/xen/arch/riscv/arch.mk > > +++ b/xen/arch/riscv/arch.mk > > @@ -12,3 +12,4 @@ riscv-march-$(CONFIG_RISCV_ISA_C) := > > $(riscv-march-y)c > > > > CFLAGS += -march=$(riscv-march-y) -mstrict-align -mcmodel=medany > > CFLAGS += -I$(BASEDIR)/include > > +CFLAGS += -I$(BASEDIR)/arch/$(TARGET_ARCH)/include > > I find it odd that this needed repeating in every arch.mk. Can't > this be done once for all arches? I actually do that much later in the series with patch "build: Add headers path to CFLAGS once for all archs". > > --- a/xen/common/page_alloc.c > > +++ b/xen/common/page_alloc.c > > @@ -241,7 +241,7 @@ PAGE_LIST_HEAD(page_broken_list); > > > > /* > > * first_valid_mfn is exported because it is use in ARM specific NUMA > > - * helpers. See comment in asm-arm/numa.h. > > + * helpers. See comment in asm/numa.h. > > */ > > mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER; > > I'm afraid that in this case it is relevant that it's Arm's header, > like ... Will fix. Thanks, -- Anthony PERARD
