On 12.10.2021 23:22, Oleksandr Tyshchenko wrote: > @@ -95,7 +95,7 @@ void getdomaininfo(struct domain *d, struct > xen_domctl_getdomaininfo *info) > > info->cpu_time = cpu_time; > > - info->flags = (info->nr_online_vcpus ? flags : 0) | > + info->flags |= (info->nr_online_vcpus ? flags : 0) | > ((d->is_dying == DOMDYING_dead) ? XEN_DOMINF_dying : 0) | > (d->is_shut_down ? XEN_DOMINF_shutdown : 0) | > (d->controller_pause_count > 0 ? XEN_DOMINF_paused : 0) |
I don't think this is a useful change - you move from a simple write to a read-modify-write operation. With this dropped again, hypervisor parts: Reviewed-by: Jan Beulich <[email protected]> While this has meanwhile moved quite far from the original proposal, I still wonder in how far Andrew may have remaining concerns. Did you check with him, perhaps on irc? But of course catching his attention may be difficult, so no (further) feedback by him should probably not keep this from getting committed (if no other open issues remain). Jan
