On 20.10.2021 09:02, Juergen Gross wrote: > On 18.10.21 17:28, Juergen Gross wrote: >> On 18.10.21 14:58, Jan Beulich wrote: >>> On 15.10.2021 14:51, Juergen Gross wrote: >>>> --- a/.gitignore >>>> +++ b/.gitignore >>>> @@ -332,10 +332,12 @@ xen/include/asm-x86/asm-macros.h >>>> xen/include/compat/* >>>> xen/include/config/ >>>> xen/include/generated/ >>>> +xen/include//hypercall-defs.i >>> >>> Nit: Stray double slash (unless this has a meaning I'm unaware of). >> >> Oh, right. No special meaning AFAIK. >> >>> Yet then I wonder: Shouldn't *.i be among the patterns at the top of >>> the file, like *.o is? >> >> Yes, I can do that. Probably via a separate patch then. > > I can't do that, as we have one source file in our git tree matching > this pattern: tools/libs/stat/bindings/swig/xenstat.i is used as an > input file for swig for generating perl and python bindings. And the > .i suffix seems to be the common one for swig input files.
Ugly. Since we have a rule to produce *.i in xen/Rules.mk, I think we really should have these ignored. Perhaps a good enough reason to put *.i in xen/.gitignore? And while at it perhaps also *.s? Unless there's a way to specify a pattern for an entire subtree - it's not clear to me whether xen/*.i in ./.gitignore would cover subdirs of xen/ as well ... Jan
