The existing code depends on precisely whether the non-default option appearing in the configure script is indeed the opposite of the option we want to pass.
Right now it seems to be working but this seems fragile. Do it differently. I have verified that with current Xen, on arm64: + egrep -q -- '--disable-xend|--enable-xend' tools/configure + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure + enable_opts=' --enable-ovmf' + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional' tools/configure + enable_opts=' --enable-ovmf --disable-qemu-traditional' + ./configure --sysconfdir=/etc --enable-ovmf --disable-qemu-traditional and on amd64: + egrep -q -- '--disable-xend|--enable-xend' tools/configure + egrep -q -- '--disable-ovmf|--enable-ovmf' tools/configure + enable_opts=' --enable-ovmf' + egrep -q -- '--disable-qemu-traditional|--enable-qemu-traditional' tools/configure + enable_opts=' --enable-ovmf --enable-qemu-traditional' + ./configure --sysconfdir=/etc --enable-ovmf --enable-qemu-traditional Juergen, I would appreciate a review from you. I think I would like this in osstest production before changing the qemu trad build default in Xen. Ian Jackson (2): ts-xen-build: Refactor enable/disable configure options ts-xen-build: Pass --enable if --disable found in usage, and v.v. ts-xen-build | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) -- 2.20.1
