On 25.10.2021 15:38, Oleksandr Andrushchenko wrote: > On 25.10.21 16:22, Roger Pau Monné wrote: >> On Fri, Oct 08, 2021 at 08:55:32AM +0300, Oleksandr Andrushchenko wrote: >>> --- a/tools/libs/light/libxl_pci.c >>> +++ b/tools/libs/light/libxl_pci.c >>> @@ -1364,6 +1364,15 @@ static void pci_add_timeout(libxl__egc *egc, >>> libxl__ev_time *ev, >>> pci_add_dm_done(egc, pas, rc); >>> } >>> >>> +static bool pci_supp_legacy_irq(void) >> A naming more inline with the PCI specification (since we insisted on >> using ECAM instead of MCFG) would be intx, ie: pci_supports_intx. > This will require a follow up patch if we all agree this change is needed. > @Jan, are you ok with the rename?
Sure, but my view doesn't matter all this much anyway for libxl code. Jan
