Arm EFI boot issue for Dom0 module listed inside subnode of chosen

[Luca Fancellu]

Hi all,

We recently discovered that there is a way to list Dom0 modules that is not 
supported by the EFI boot,
It’s happened browsing some Wiki pages like this one:
https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions/Lager

In that page the Dom0 modules are listed inside a subnode of the /chosen node:

chosen {

    modules {
        #address-cells = <1>;
        #size-cells = <1>;

        module@0x72000000 {
            compatible = "multiboot,kernel", "multiboot,module";
            reg = <0x72000000 0x2fd158>;
        };

        module@0x74000000 {
            compatible = "xen,xsm-policy", "multiboot,module";
            reg = <0x74000000 0x2559>;
        };
    };
};

Instead for how it is implemented now in the EFI code and described in:
1) https://xenbits.xen.org/docs/unstable/misc/arm/device-tree/booting.txt
2) https://xenbits.xen.org/docs/unstable/misc/efi.html

Only the following approach is supported, so Dom0 modules must be a direct 
child of /chosen:

chosen {
    #address-cells = <1>;
    #size-cells = <1>;

    module@0x72000000 {
        compatible = "multiboot,kernel", "multiboot,module";
        reg = <0x72000000 0x2fd158>;
    };

    module@0x74000000 {
        compatible = "xen,xsm-policy", "multiboot,module";
        reg = <0x74000000 0x2559>;
    };
};

Is this a problem that needs a fix?

Thank you.

Cheers,
Luca