On 04.11.2021 10:16, Roger Pau Monné wrote:
> On Thu, Nov 04, 2021 at 09:55:03AM +0100, Jan Beulich wrote:
>> On 03.11.2021 15:57, Roger Pau Monne wrote:
>>> @@ -69,7 +69,8 @@ int gnttab_acquire_resource(
>>>
>>> static inline int grant_table_init(struct domain *d,
>>> int max_grant_frames,
>>> - int max_maptrack_frames)
>>> + int max_maptrack_frames,
>>> + unsigned int options)
>>> {
>>> return 0;
>>> }
>>
>> While arbitrary table size requests may be okay to ignore here, I'm
>> unsure about the max-version: Requesting v3 is surely an error in any
>> event; I'd even be inclined to suggest requesting v1 or v2 is as
>> well. Adding such a check here looks like it would be compatible with
>> all the other adjustments you're making.
>
> I think if the grant table is disabled at build time we should only
> accept version 0 as valid here.
IOW "options" as a whole then wants to be checked against zero.
Jan
