Hi Jan, Thanks for reviewing the patches. Yeah, I messed it up while breaking the code into multiple patches. For next v3 patch series, I will move the function call "handle_add_overlay_nodes()"(in patch 8/12) to 9/12 patch.
Thanks, Vikram ________________________________ From: Jan Beulich <jbeul...@suse.com> Sent: Tuesday, November 9, 2021 3:19 AM To: Vikram Garhwal <f...@xilinx.com> Cc: sstabell...@kernel.org <sstabell...@kernel.org>; jul...@xen.org <jul...@xen.org>; bertrand.marq...@arm.com <bertrand.marq...@arm.com>; volodymyr_babc...@epam.com <volodymyr_babc...@epam.com>; Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap <george.dun...@citrix.com>; Ian Jackson <i...@xenproject.org>; Wei Liu <w...@xen.org>; xen-devel@lists.xenproject.org <xen-devel@lists.xenproject.org> Subject: Re: [XEN][RFC PATCH v2 09/12] xen/arm: Implement device tree node addition functionalities On 09.11.2021 08:02, Vikram Garhwal wrote: > --- a/xen/common/sysctl.c > +++ b/xen/common/sysctl.c > @@ -331,6 +331,205 @@ out: > spin_unlock(&overlay_lock); > return rc; > } > + > +/* > + * Adds device tree nodes under target node. > + * We use dt_host_new to unflatten the updated device_tree_flattened. This is > + * done to avoid the removal of device_tree generation, iomem regions > mapping to > + * hardware domain done by handle_node(). > + */ > +static long handle_add_overlay_nodes(void *overlay_fdt, > + uint32_t overlay_fdt_size) You adding a static function here without any caller got me puzzled. First I thought you'd be introducing a build failure this was, but it's really patch 8 which does by introducing a call to this function without the function actually being there. Jan
