On 26.11.2021 13:34, Andrew Cooper wrote: > The function pointer cast in hvm_vcpu_initialise() is undefined behaviour. > > While it happens to function correctly before this point, it is not > incompatible with control flow typechecking,
DYM "is now incompatible" or "is not compatible"? > so introduce a new > hvm_assert_evtchn_irq_tasklet() to handle the parameter type conversion in a > legal way. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > CC: Wei Liu <w...@xen.org> > CC: Julien Grall <jul...@xen.org> > CC: Roger Pau Monné <roger....@citrix.com> > --- > xen/arch/x86/hvm/hvm.c | 7 ++++++- > xen/arch/x86/hvm/vlapic.c | 2 +- > xen/arch/x86/mm/shadow/common.c | 2 +- > xen/common/domain.c | 2 +- > xen/common/keyhandler.c | 6 +++--- > xen/common/livepatch.c | 2 +- > xen/common/stop_machine.c | 2 +- > xen/common/trace.c | 2 +- > xen/drivers/char/console.c | 2 +- > xen/drivers/passthrough/amd/iommu_guest.c | 2 +- > xen/drivers/passthrough/amd/iommu_init.c | 4 ++-- > xen/drivers/passthrough/arm/smmu-v3.c | 6 +++--- Wrt my remark in an earlier patch - any reason that here you do touch an Arm-only file? Jan