On 29.11.2021 20:44, Ayan Kumar Halder wrote: > GENMASK(30, 21) should be 0x07fe00000
Please can this have a meaningful title? E.g. "bitops: fix incorrect value in comment"? > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -5,7 +5,7 @@ > /* > * Create a contiguous bitmask starting at bit position @l and ending at > * position @h. For example > - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000. > + * GENMASK(30, 21) gives us the 32bit vector 0x07fe00000. Once at it I think you also want to - replace the word "vector", - drop the odd leading 0: The number would better be 8 digits or 16 digits, but not 9. Jan