On 01/12/2021 10:53, Jan Beulich wrote: > Pinning is a PV concept, used there only for page table pages. > > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Andrew Cooper <[email protected]> Perhaps this is a leftover from autotranslate mode? That was doing some very HVM-like things for PV guests. > --- > I'm actually inclined to hide _PGT_pinned in !HVM builds; the downside > of doing so is some new #ifdef-ary which would need adding. Judging by the current users, I doubt it is worth it, although folding this delta wouldn't go amiss. diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h index cb9052749963..e5f63daa1a71 100644 --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@ -36,7 +36,7 @@ /* Page is locked? */ #define _PGT_locked PG_shift(4) #define PGT_locked PG_mask(1, 4) - /* Owning guest has pinned this page to its current type? */ + /* Owning guest has pinned this page to its current type? PV only */ #define _PGT_pinned PG_shift(5) #define PGT_pinned PG_mask(1, 5) /* Has this page been validated for use as its current type? */ ~Andrew
