On 01.12.2021 16:13, Andrew Cooper wrote: > On 01/12/2021 09:39, Jan Beulich wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -1457,24 +1462,24 @@ static int iommu_get_device_group( >> if ( !is_iommu_enabled(d) || !ops->get_device_group_id ) >> return 0; >> >> - group_id = ops->get_device_group_id(seg, bus, devfn); >> + group_id = iommu_call(ops, get_device_group_id, seg, bus, devfn); > > So I was going to suggest adjusting this to use more pci_sbdf_t, but the > Intel implementation can fail and return -1.
How are the two aspects related? Wouldn't you mean the parameter of the function to become pci_sbdf_t? If so, I'd view this as an orthogonal change. I'll reply to the question of removal on the subthread of patch 4. Jan
