On 03.12.2021 12:21, Andrew Cooper wrote: > On 03/12/2021 10:56, Jan Beulich wrote: >> When it was introduced, it was imo placed way too high up, making it >> necessary to forward-declare way too many static functions. Move it down >> together with >> - the efi_check_dt_boot() stub, which afaict was deliberately placed >> immediately ahead of the #include, >> - blexit(), because of its use of the efi_arch_blexit() hook. >> Move up get_value() and set_color() to before the inclusion so their >> forward declarations can also be zapped. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Why does blexit() need moving? It isn't static, and has a real > prototype in efi.h
Correct, but the movement is for the functions it uses from efi-boot.h: efi_arch_halt() and efi_arch_blexit() at least (which actually the commit message also says, for one of the two at least). Jan
