On Thu, Dec 02, 2021 at 03:06:54PM +0100, Jan Beulich wrote: > On 25.11.2021 14:39, Anthony PERARD wrote: > > +efi-check-o := arch/x86/efi/check.o > > How about making this > > efi-check := arch/x86/efi/check > > That way you wouldn't need to replace the extension in a number of places, > but simply append the respective one in every place using this.
This change sound fine. I guess it will make reading the code a bit easier. > > +export XEN_BUILD_EFI XEN_BUILD_PE MKRELOC > > +export EFI_LDFLAGS > > +endif > > Exporting MKRELOC in particular isn't very nice. I wonder whether there > wouldn't be a way to keep it local to xen/Makefile. I don't think that's possible. The value of MKRELOC depends on a call with OBJDUMP which depends on call with LD which depends on a call with CC. And the call with CC is the one I'm trying to move. Unless there is a better way to build *.efi, we need to know whether to use `mkreloc` or not. I could rename it XEN_MKRELOC. Or if there is another name that could make sense, that would be fine too, like XEN_BUILD_EFI_NEED_RELOC which could be a boolean. Thanks, -- Anthony PERARD
