Re: [PATCH v4 08/11] xen/arm: gate make_gicv3_domU_node with CONFIG_GICV3

[Stefano Stabellini]

On Mon, 20 Dec 2021, Penny Zheng wrote:
> This commit gates function make_gicv3_domU_node with CONFIG_GICV3.
> 
> Signed-off-by: Penny Zheng <penny.zh...@arm.com>

Acked-by: Stefano Stabellini <sstabell...@kernel.org>


> ---
> v4 changes:
> - remove ASSERT_UNREACHABLE() to avoid breaking compilation on prod build with
> CONFIG_GICV3=n
> ---
>  xen/arch/arm/domain_build.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 4788b03d8b..139d428524 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -2322,6 +2322,7 @@ static int __init make_gicv2_domU_node(struct 
> kernel_info *kinfo)
>      return res;
>  }
>  
> +#ifdef CONFIG_GICV3
>  static int __init make_gicv3_domU_node(struct kernel_info *kinfo)
>  {
>      void *fdt = kinfo->fdt;
> @@ -2371,13 +2372,16 @@ static int __init make_gicv3_domU_node(struct 
> kernel_info *kinfo)
>  
>      return res;
>  }
> +#endif
>  
>  static int __init make_gic_domU_node(struct kernel_info *kinfo)
>  {
>      switch ( kinfo->d->arch.vgic.version )
>      {
> +#ifdef CONFIG_GICV3
>      case GIC_V3:
>          return make_gicv3_domU_node(kinfo);
> +#endif
>      case GIC_V2:
>          return make_gicv2_domU_node(kinfo);
>      default:
> -- 
> 2.25.1
>