On 18.01.2022 12:06, Anthony PERARD wrote: > On Tue, Dec 21, 2021 at 02:53:49PM +0100, Jan Beulich wrote: >> On 25.11.2021 14:39, Anthony PERARD wrote: >>> Rather than preparing the efi source file, we will make the symbolic >>> link as needed from the build location. >>> >>> The `ln` command is run every time to allow to update the link in case >>> the source tree change location. >> >> Btw, since symlinks aren't being liked, would there be a way to make >> things work using vpath? > > No, that's not possible. With "vpath = /build/xen/common/efi", make > would look at path "/build/xen/common/efi/arch/x86/efi/runtime.c" to > build "arch/x86/efi/runtime.o".
But /build/xen/common/efi/arch/x86/efi/runtime.c doesn't exist (and never will afaict), so wouldn't make go on finding the file elsewhere? >>> +clean-files += $(patsubst %.o,%.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-)) >> >> Nit: Please be consistent (at least within a single line) about blanks >> following commas. > > You mean to never put spaces after a comma because they are sometime > significant? That's the only way I know how to be consistent. When spaces are significant, they of course cannot be stripped. But here they aren't (afaict), and hence clean-files += $(patsubst %.o,%.c,$(EFIOBJ-y:.init.o=.o) $(EFIOBJ-)) or clean-files += $(patsubst %.o, %.c, $(EFIOBJ-y:.init.o=.o) $(EFIOBJ-)) are the two consistent (in my eyes) forms. Jan
