Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 2022年1月25日 17:49 > To: Wei Chen <wei.c...@arm.com> > Cc: Bertrand Marquis <bertrand.marq...@arm.com>; xen- > de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org > Subject: Re: [PATCH 13/37] xen/x86: decouple processor_nodes_parsed from > acpi numa functions > > On 23.09.2021 14:02, Wei Chen wrote: > > --- a/xen/arch/x86/srat.c > > +++ b/xen/arch/x86/srat.c > > @@ -104,6 +104,11 @@ nodeid_t setup_node(unsigned pxm) > > return node; > > } > > > > +void __init numa_set_processor_nodes_parsed(nodeid_t node) > > Besides (nit) the stray blank here, earlier comments apply. The way you > do the rearrangement it is close to impossible to see the actual "why" > behind the changes. Even if it would make for a bigger patch, I think > you want to collapse patches and move things out of srat.c code while > you split out generically usable functionality. Or, if the result was > deemed to large a patch to have all in one go, make the movement of > individual static variables the topic of each patch, introducing > accessor functions like the one here. >
Thanks, I will fix them in next version. > Jan
