> -----Original Message----- > From: Julien Grall [mailto:julien.gr...@arm.com] > Sent: 03 April 2018 15:08 > To: Paul Durrant <paul.durr...@citrix.com>; xen-devel@lists.xenproject.org > Cc: Jan Beulich <jbeul...@suse.com>; George Dunlap > <george.dun...@citrix.com>; Wei Liu <wei.l...@citrix.com>; Andrew > Cooper <andrew.coop...@citrix.com>; Ian Jackson > <ian.jack...@citrix.com>; Konrad Rzeszutek Wilk > <konrad.w...@oracle.com>; Stefano Stabellini <sstabell...@kernel.org>; Tim > (Xen.org) <t...@xen.org> > Subject: Re: [PATCH v19 06/11] x86/hvm/ioreq: add a new mappable > resource type... > > Hi Paul, > > On 29/03/18 16:36, Paul Durrant wrote: > > diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h > > index a0e922f360..8cddf484d8 100644 > > --- a/xen/include/asm-arm/mm.h > > +++ b/xen/include/asm-arm/mm.h > > @@ -374,6 +374,14 @@ static inline void put_page_and_type(struct > page_info *page) > > > > void clear_and_clean_page(struct page_info *page); > > > > +static inline int arch_acquire_resource( > > I would much prefer to see "static inline" on a separate line and get > the parameters correctly indented. > > With that: > > Acked-by: Julien Grall <julien.gr...@arm.com> >
Thanks. Can the formatting be fixed on commit please? Paul > Cheers, > > -- > Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
