On 28.01.2022 17:49, Tamas K Lengyel wrote: > On Thu, Jan 27, 2022 at 10:07 AM Jan Beulich <[email protected]> wrote: >> @@ -2549,15 +2546,16 @@ int p2m_altp2m_propagate_change(struct d >> >> for ( i = 0; i < MAX_ALTP2M; i++ ) >> { >> + p2m_type_t t; >> + p2m_access_t a; >> + >> if ( d->arch.altp2m_eptp[i] == mfn_x(INVALID_MFN) ) >> continue; >> >> p2m = d->arch.altp2m_p2m[i]; >> - m = get_gfn_type_access(p2m, gfn_x(gfn), &t, &a, 0, NULL); >> >> /* Check for a dropped page that may impact this altp2m */ >> - if ( mfn_eq(mfn, INVALID_MFN) && >> - gfn_x(gfn) >= p2m->min_remapped_gfn && >> + if ( gfn_x(gfn) + (1UL << page_order) > p2m->min_remapped_gfn && >> gfn_x(gfn) <= p2m->max_remapped_gfn ) > > Why are you dropping the mfn_eq(mfn, INVALID_MFN) check here?
Thanks for spotting - this is a mistake in the v3 rework. Jan
