On Mon, Feb 07, 2022 at 01:41:38PM +0100, Jan Beulich wrote: > On 07.02.2022 12:20, Roger Pau Monne wrote: > > Make sure softirqs are processed after every successful call to > > guest_physmap_add_page. Even if only a single page is to be added, > > it's unknown whether the p2m or the IOMMU will require splitting the > > provided page into smaller ones, and thus in case of having to break > > a 1G page into 4K entries the amount of time taken by a single of > > those additions will be non-trivial. Stay on the safe side an check > > for pending softirqs on ever successful loop iteration. > > > > Fixes: 5427134eae ('x86: populate PVHv2 Dom0 physical memory map') > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Reviewed-by: Jan Beulich <jbeul...@suse.com> > > Nit: I guess it's "and" and "every" in the last sentence. I'd be > happy to adjust while committing.
Yes please, if you are happy to adjust on commit. Thanks, Roger.