On 14/02/2022 13:38, Jan Beulich wrote: > On 14.02.2022 13:50, Andrew Cooper wrote: >> Control Flow Integrity schemes use toolchain and optionally hardware support >> to help protect against call/jump/return oriented programming attacks. >> >> Use cf_check to annotate function pointer targets for the toolchain. >> >> pv_emul_is_mem_write() is only used in a single file. Having it as a static >> inline is pointless because it can't be inlined to begin with. > I'd like you to consider to re-word this:
This is the reworded version. > It being static inline was for > the case of there appearing a 2nd user. I don't view such as pointless. I find that impossible to reconcile with your normal review feedback. It is unconditionally forced out of line because of how it's used, meaning that if it ever got used in a second translation unit we'd end up with a duplicate function, at which point it would need to be non-static and exported to pass review. (And sanity.) ~Andrew
