> On 25 Feb 2022, at 16:28, Anthony PERARD <[email protected]> wrote:
>
> On Fri, Feb 25, 2022 at 03:30:59PM +0000, Christian Lindig wrote:
>>
>>
>>> On 25 Feb 2022, at 15:13, Anthony PERARD <[email protected]> wrote:
>>>
>>> This patch fix ".ocamldep.make" rule by always spelling the variable
>>> $(OCAML_TOPLEVEL).
>>>
>>> Signed-off-by: Anthony PERARD <[email protected]>
>>> ---
>>>
>>> Notes:
>>> v2:
>>> - new patch
>>>
>>> tools/ocaml/libs/eventchn/Makefile | 8 ++++----
>>> tools/ocaml/libs/mmap/Makefile | 8 ++++----
>>> tools/ocaml/libs/xb/Makefile | 8 ++++----
>>> tools/ocaml/libs/xc/Makefile | 8 ++++----
>>> tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
>>> tools/ocaml/libs/xl/Makefile | 8 ++++----
>>> tools/ocaml/libs/xs/Makefile | 8 ++++----
>>> tools/ocaml/Makefile.rules | 2 +-
>>
>> Acked-by: Christian Lindig <[email protected]>
>>
>> I am fine with this but in general think that the OCaml part should be built
>> using Dune (but invoked from Make), which is now the standard tool to build
>> OCaml projects and is simple, fast, and accurate. Edwin maintains such a
>> build for all development work on the OCaml side but it is not upstreamed.
>
> ocaml-dune doesn't seems to be available on debian oldstable. So I don't
> think we can use it for now.
>
> But thanks for pointing that out.
>
I think we should try to add it as an optional build-system: when available use
it, and at some point in the future remove the old one.
It is pretty much impossible to do development on the codebase without it, any
developer who wants to make the changes to the OCaml code will likely want it.
(Of course those who only want to build and install oxenstored may not require
dune, and may be fine with the Makefiles as they wouldn't require incremental
builds or editor support).
Best regards,
--Edwin
> --
> Anthony PERARD
