Jan,
FYI, I just noticed that Lukasz old intel email was used for this patch.
I assume your tree just hasn't picked up the patch with his new email
address. Copying him now so he can see your patch.
v/r,
dps
On 3/3/22 06:50, Daniel P. Smith wrote:
On 3/3/22 04:49, Jan Beulich wrote:
We shouldn't include unsupported code by default, with not even a means
for its building to be disabled. Convert the dependency from merely
affecting the prompt's visibility to a real one.
Signed-off-by: Jan Beulich <jbeul...@suse.com>
---
We could of course go further and make the default also account for
DEBUG, as is done elsewhere.
As in you would like to adjust the default based on whether DEBUG is on
or not? I guess my question is what motivation is there to adjust this
selection if DEBUG is enabled or disabled?
--- a/xen/arch/x86/Kconfig
+++ b/xen/arch/x86/Kconfig
@@ -193,14 +193,15 @@ config HVM_FEP
If unsure, say N.
config TBOOT
- bool "Xen tboot support (UNSUPPORTED)" if UNSUPPORTED
- default y if !PV_SHIM_EXCLUSIVE
+ bool "Xen tboot support (UNSUPPORTED)"
+ depends on UNSUPPORTED
+ default !PV_SHIM_EXCLUSIVE
select CRYPTO
---help---
Allows support for Trusted Boot using the Intel(R) Trusted
Execution
Technology (TXT)
- If unsure, say Y.
+ If unsure, stay with the default.
choice
prompt "Alignment of Xen image"
Outside of the debug question, I think the proposed change is good.
Reviewed-by: Daniel P. Smith <dpsm...@apertussolutions.cm>
