On Tue, Mar 08, 2022 at 04:16:21PM +0000, Jane Malalane wrote: > On 08/03/2022 16:02, Roger Pau Monné wrote: > > On Tue, Mar 08, 2022 at 03:44:18PM +0000, Jane Malalane wrote: > >> On 08/03/2022 11:38, Roger Pau Monné wrote: > >>> On Mon, Mar 07, 2022 at 03:06:09PM +0000, Jane Malalane wrote: > >>>> diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > >>>> b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > >>>> index 9119aa8536..5b7d662ed7 100644 > >>>> --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > >>>> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h > >>>> @@ -220,6 +220,9 @@ void vmx_vmcs_reload(struct vcpu *v); > >>>> #define CPU_BASED_ACTIVATE_SECONDARY_CONTROLS 0x80000000 > >>>> extern u32 vmx_cpu_based_exec_control; > >>>> > >>>> +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic) > >>>> +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic) > >>> > >>> Those macros should not be in an Intel specific header, > >>> arch/x86/include/asm/hvm/domain.h is likely a better place. > >> > >> Actually do you think hvm.h could be better? > > > > I guess that's also fine, I did suggest hvm/domain.h because that's > > where the fields get declared. I guess you prefer hvm.h because there > > are other HVM related helpers in there? > > Yeah, that is why - tsc_scaling_ratio also gets defined in domain.h for e.g.
I'm fine with placing it in hvm.h. Thanks, Roger.
