On 23.03.22 12:22, Luca Fancellu wrote:
On 23 Mar 2022, at 11:10, Luca Fancellu <[email protected]> wrote:On 23 Mar 2022, at 08:58, Juergen Gross <[email protected]> wrote: The result field of struct vscsiif_response is lacking a detailed definition. Today the Linux kernel internal scsi definitions are being used, which is not a sane interface for a PV device driver. Add macros to change that by using today's values in the XEN namespace. Signed-off-by: Juergen Gross <[email protected]> --- V2: - put macro parameters in parentheses (Jan Beulich) - correct XEN_VSCSIIF_RSLT_HOST() (Jan Beulich) - more verbose result defines (Jan Beulich) - add reset result defines (Jan Beulich) --- xen/include/public/io/vscsiif.h | 51 +++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/xen/include/public/io/vscsiif.h b/xen/include/public/io/vscsiif.h index c9ceb1884d..8553b17cc6 100644 --- a/xen/include/public/io/vscsiif.h +++ b/xen/include/public/io/vscsiif.h @@ -315,6 +315,57 @@ struct vscsiif_response { }; typedef struct vscsiif_response vscsiif_response_t; +/* SCSI I/O status from vscsiif_response->rslt */ +#define XEN_VSCSIIF_RSLT_STATUS(x) ((x) & 0x00ff)Sorry Juergen, A thing came to me after sending my first message, is XEN_VSCSIIF_RSLT_STATUS meant to be used to compare the result with XEN_VSCSIIF_RSLT_RESET_SUCCESS or XEN_VSCSIIF_RSLT_RESET_FAILED?
No. XEN_VSCSIIF_RSLT_RESET_* are meant to be compared with vscsiif_response->rslt. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
