Hi Stefano, On 16.04.2022 01:10, Stefano Stabellini wrote: > On Thu, 14 Apr 2022, Michal Orzel wrote: >> DT_MATCH_TIMER stores the compatible timer ids and as such should be >> used in all the places where we need to refer to them. make_timer_node >> explicitly lists the same ids as the ones defined in DT_MATCH_TIMER so >> make use of this macro instead. >> >> Signed-off-by: Michal Orzel <michal.or...@arm.com> > > This is a good cleanup, thanks! time.h is not currently included by > domain_build.c, I think we should add: > > #include <asm/time.h> > > to domain_build.c > asm/time.h is included by xen/time.h which is included by xen/irq.h. That is why there is no build failure and the patch itself is correct.
Furthermore DT_MATCH_TIMER is already used in domain_build.c (handle_node) together with other constructs like TIMER_PHYS_SECURE_PPI defined in asm/time.h. Cheers, Michal
