On 19.04.2022 11:22, Juergen Gross wrote: > On 19.04.22 10:42, Jan Beulich wrote: >> On 16.04.2022 15:31, Juergen Gross wrote: >> And finally I think iommu_do_domctl() needs making resilient against d >> coming in as NULL. This isn't just to cover the issue here, but perhaps >> more importantly because XEN_DOMCTL_test_assign_device can legitimately >> end up having NULL passed here (when the caller passed DOMID_INVALID). >> We've simply been lucky that libxl doesn't use this variant of calling >> this domctl. I guess when d is NULL we ought to check the global flag >> there rather than the per-domain one. > > I think this should be another patch, though.
Sure. I'm happy to make one. Jan
