On Mon, Apr 25, 2022 at 10:36:42AM +0200, Jan Beulich wrote: > This is to aid diagnosing issues and largely matches VT-d's behavior. > Since I'm adding permissions output here as well, take the opportunity > and also add their displaying to amd_dump_page_table_level(). > > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Roger Pau Monné <[email protected]> > --- > Note: "largely matches VT-d's behavior" includes the lack of any locking > here. Adding suitable locking may not be that easy, as we'd need > to determine which domain's mapping lock to acquire in addition to > the necessary IOMMU lock (for the device table access), and > whether that domain actually still exists. The latter is because > if we really want to play safe here, imo we also need to account > for the device table to be potentially corrupted / stale. I think that's fine. Thanks, Roger.
