On 05.05.2022 04:54, Henry Wang wrote: > xmalloc() will use a pool for allocation smaller than a page. > The pool is extended only when there are no more space. At which > point, alloc_xenheap_pages() is called to add more memory. > > xmalloc() must be protected by ASSERT_ALLOC_CONTEXT. It should not > rely on pool expanding to trigger the ASSERT_ALLOC_CONTEXT in > alloc_xenheap_pages(). Hence, this commit moves the definition of > ASSERT_ALLOC_CONTEXT to header and uses the ASSERT_ALLOC_CONTEXT > to replace the original assertion in xmalloc(). > > Reported-by: Wei Chen <[email protected]> > Suggested-by: Julien Grall <[email protected]> > Signed-off-by: Henry Wang <[email protected]> > Change-Id: Ia463d2241e80e8a78d7dbb5b2318694d3ca5ed67
Just two formal remarks for starters: What's this last tag? And why am I on the To: list of this patch, when ... > --- > xen/common/page_alloc.c | 7 ------- > xen/common/xmalloc_tlsf.c | 2 +- > xen/include/xen/irq.h | 7 +++++++ > 3 files changed, 8 insertions(+), 8 deletions(-) ... with this diffstat you should instead have _Cc_-ed REST maintainers? Jan
