On 5/4/22 8:23 PM, Stefano Stabellini wrote:
@@ -957,25 +989,44 @@ static int __init xenbus_init(void)
                 * been properly initialized. Instead of attempting to map a
                 * wrong guest physical address return error.
                 *
-                * Also recognize all bits set as an invalid value.
+                * Also recognize all bits set as an invalid/uninitialized 
value.


What I really meant (but not what I actually wrote I guess) was that now we are 
treating -1 differently than 0 and so that comment should go ...


                 */
-               if (!v || !~v) {
+               if (!v) {
                        err = -ENOENT;
                        goto out_error;
                }
-               /* Avoid truncation on 32-bit. */


... here.


But this is ntpicking so for the series


Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>


+               if (v == ~0ULL) {
+                       wait = true;
+               } else {
+                       /* Avoid truncation on 32-bit. */

Reply via email to