On 05.05.2022 16:21, Roger Pau Monne wrote: > Current LLVM LD implementation will turn global hidden symbols in > object files into local ones when generating the .symtab of the Xen > binary image. > > This is different from GNU ld implementation, that will only do the > conversion (or remove the symbols) when generation .dynsym but not > .symtab. Such conversion breaks the processing of symbols done by > tools/symbols. > > Use protected symbol visibility instead of hidden, as that preserves > the symbol binding while not generating GOT or PLT indirections that > are not compatible with some of the inline assembly constructs > currently used. > > While there also make the visibility setting compiler support > non-optional: compilers not supporting it won't be able to build Xen > anyway, and will just throw a compiler error sooner rather than later > during the build. > > Signed-off-by: Roger Pau Monné <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>
