> On May 16, 2022, at 4:20 PM, Julien Grall <[email protected]> wrote: > > > > On 16/05/2022 16:04, Andrew Cooper wrote: >> On 13/05/2022 15:33, George Dunlap wrote: > >> IMO, a commit message saying "port $X from project $Y" makes it crystal >> clear that the original code change isn't mine, but the porting effort >> is. Amongst other things, porting invalidates any review/ack/test chain >> because those tags were given in the context of the original project, >> not Xen. > > This seems to contradict our documentation: > > "All tags **above** the `Origin:` tag are from the original patch (which > should all be kept), while tags **after** `Origin:` are related to the > normal Xen patch process as described here."
And indeed, part of the the point of that paragraph is almost certainly to clue you in that the “Tested-by:” is for the original commit, not the Xen commit. That paragraph is clearly expecting the case where individual commits are cherry-picked, not batched or done with an entire file. In large part we seem to be in agreement, so we just need someone to do some wordsmithing of some text to update that file for the “batch update” and “import a full file” cases. -George
signature.asc
Description: Message signed with OpenPGP
