Hi Andrew, > On 17 May 2022, at 14:01, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > On 06/05/2022 13:00, Luca Fancellu wrote: >> Introduce domain-cpupool property of a xen,domain device tree node, >> that specifies the cpupool device tree handle of a xen,cpupool node >> that identifies a cpupool created at boot time where the guest will >> be assigned on creation. >> >> Add member to the xen_domctl_createdomain public interface so the >> XEN_DOMCTL_INTERFACE_VERSION version is bumped. >> >> Add public function to retrieve a pool id from the device tree >> cpupool node. >> >> Update documentation about the property. >> >> Signed-off-by: Luca Fancellu <luca.fance...@arm.com> >> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > > This has broken the Ocaml bindings, and is conceptually wrong.
Ok, can you tell me what to do to update the Ocaml bindings? Do we have some resources somewhere? > > The cpupool to use is a property of the vcpu, not the domain. It isn't > legitimately part of createdomain. I agree with Juergen on that, could you explain it better for me to understand your point? > > ~Andrew
