Re: [PATCH] x86/mwait-idle: add missing newline

[Jan Beulich]

On 16.05.2022 12:36, Roger Pau Monne wrote:
> Fixes: 5a211704e8 ('mwait-idle: prevent SKL-H boot failure when C8+C9+C10 
> enabled')
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>

Thanks for spotting. I wonder whether we shouldn't mention the Linux
commit (654d08a42a56) which did this as a "side effect". Obviously
the fix here isn't really a port thereof.

Jan

> --- a/xen/arch/x86/cpu/mwait-idle.c
> +++ b/xen/arch/x86/cpu/mwait-idle.c
> @@ -1363,7 +1363,7 @@ static int cf_check mwait_idle_cpu_init(
>               /* if state marked as disabled, skip it */
>               if (cpuidle_state_table[cstate].flags &
>                   CPUIDLE_FLAG_DISABLED) {
> -                     printk(XENLOG_DEBUG PREFIX "state %s is disabled",
> +                     printk(XENLOG_DEBUG PREFIX "state %s is disabled\n",
>                              cpuidle_state_table[cstate].name);
>                       continue;
>               }