On 17.05.2022 11:05, Penny Zheng wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -780,6 +780,11 @@ void __init setup_system_domains(void) > * This domain owns I/O pages that are within the range of the page_info > * array. Mappings occur at the priv of the caller. > * Quarantined PCI devices will be associated with this domain. > + * > + * DOMID_IO could also be used for mapping memory when no explicit > + * domain is specified. > + * For instance, DOMID_IO is the owner of memory pre-shared among > + * multiple domains at boot time, when no explicit owner is specified. > */ > dom_io = domain_create(DOMID_IO, NULL, 0); > if ( IS_ERR(dom_io) )
I'm sorry: The comment change is definitely better now than it was, but it is still written in a way requiring further knowledge to understand what it talks about. Without further context, "when no explicit domain is specified" only raises questions. I would have tried to make a suggestion, but I can't really figure what it is that you want to get across here. Jan
