On 23.05.2022 12:12, Julien Grall wrote: > On 23/05/2022 10:52, Lin Liu wrote: >> Update to use byteswap to swap bytes. > > I am still objecting on switching from be*_to_cpup() to be*_to_cpu().
And I agree. Especially the cast to explicitly aligned types in get_unaligned_*() is rather unhelpful (and kind of a lie) imo. Jan > I will not Nack, however the strict minimum is to explain why you want > to replace the helpers as I think the reason that was currently provided > is incorrect. > > Cheers, >
