On 01.06.2022 05:59, Alistair Francis wrote: > On Tue, May 31, 2022 at 5:09 PM Xie Xun <[email protected]> wrote: >> --- /dev/null >> +++ b/xen/arch/riscv/early_printk.c > > This should be named differently. This file should be called > `sbi_console_early_printk.c` to better indicate that it's using the > sbi_console
To not go overboard with file name length, perhaps sbi-earlyprintk.c or sbi-early-printk.c would suffice? Or, if other variants are to appear, *-sbi.c? > The SBI print functions are useful, but they have been marked as > deprecated with no future replacement (see > https://github.com/riscv-non-isa/riscv-sbi-doc/blob/659950dc57f9840cf8242c1cff138c2ee67634bb/riscv-sbi.adoc#5-legacy-extensions-eids-0x00---0x0f) > > For the initial port I think it's ok to use these, but this isn't a > long term solution, we should aim to migrate to using the standard > hardware UART. > > I'm sure Xen already has a driver for the ns16550 UART so it might be > worth just using that directly and not worrying with the sbi_console. Of course we have a driver for that, but depending on the device flavors in use on RISC-V it may require touching. Jan
