Hi Jan, > On 9 Jun 2022, at 11:12, Jan Beulich <jbeul...@suse.com> wrote: > > On 09.06.2022 11:34, Bertrand Marquis wrote: >> cppcheck MISRA addon can be used to check for non compliance to some of >> the MISRA standard rules. >> >> Add a CPPCHECK_MISRA variable that can be set to "y" using make command >> line to generate a cppcheck report including cppcheck misra checks. >> >> When MISRA checking is enabled, a file with a text description suitable >> for cppcheck misra addon is generated out of Xen documentation file >> which lists the rules followed by Xen (docs/misra/rules.rst). >> >> By default MISRA checking is turned off. >> >> While adding cppcheck-misra files to gitignore, also fix the missing / >> for htmlreport gitignore >> >> Signed-off-by: Bertrand Marquis <bertrand.marq...@arm.com> >> --- >> Changes in v2: >> - fix missing / for htmlreport >> - use wildcard for cppcheck-misra remove and gitignore >> - fix comment in makefile >> - fix dependencies for generation of json and txt file >> --- >> .gitignore | 3 +- >> xen/Makefile | 29 ++++++- >> xen/tools/convert_misra_doc.py | 139 +++++++++++++++++++++++++++++++++ >> 3 files changed, 168 insertions(+), 3 deletions(-) >> create mode 100755 xen/tools/convert_misra_doc.py >> >> diff --git a/.gitignore b/.gitignore >> index 18ef56a780..b106caa7a9 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -297,6 +297,7 @@ xen/.banner >> xen/.config >> xen/.config.old >> xen/.xen.elf32 >> +xen/cppcheck-misra.* > > As said on v1, this wants to be added further down, while ... > >> xen/xen-cppcheck.xml > > ... this line wants moving down at this occasion or in a separate > change. > >> xen/System.map >> xen/arch/x86/boot/mkelf32 >> @@ -318,7 +319,7 @@ xen/arch/*/efi/runtime.c >> xen/arch/*/include/asm/asm-offsets.h >> xen/common/config_data.S >> xen/common/config.gz >> -xen/cppcheck-htmlreport >> +xen/cppcheck-htmlreport/ >> xen/include/headers*.chk >> xen/include/compat/* >> xen/include/config/ > > xen/cppcheck-misra.* wants to go alongside the line you adjust, while > xen/xen-cppcheck.xml belongs yet further down.
Sorry I forgot that part in my v2. I will do all fixes including xen-cppcheck.xml one in a v3 shortly. Cheers Bertrand
