On Tue, 14 Jun 2022, Michal Orzel wrote: > On 14.06.2022 13:08, Julien Grall wrote: > >>> + unsigned int rc = 0; > >> ... here you are setting rc to 0 even though it will be reassigned. > >> Furthermore, if rc is used only in case of CPU_UP_PREPARE, why not moving > >> the definition there? > > > > Because I forgot to replace "return NOTIFY_DONE;" with : > > > > return !rc ? NOTIFY_DONE : notifier_from_errno(rc); > That is what I thought. > With these fixes you can add my Rb.
And also my Acked-by: Stefano Stabellini <[email protected]>
