On 21/06/2022 09:43, Michal Orzel wrote:
Hi Julien,
Hi Michal,
On 20.06.2022 11:54, Julien Grall wrote:
Hi Michal,
On 20/06/2022 08:02, Michal Orzel wrote:
According to MISRA C 2012 Rule 8.1, types shall be explicitly
specified. Fix all the findings reported by cppcheck with misra addon
by substituting implicit type 'unsigned' to explicit 'unsigned int'.
Bump sysctl interface version.
The sysctl version should only be bumped if the ABI has changed. AFAICT switching from
"unsigned" to "unsigned" will not modify it, so I don't think this is necessary.
Sure, I can remove that in v2 but first I'd like to wait at least for xsm patch
to be reviewed.
Also as these patches are not dependent from each other, do you think it is
worth respinning the reviewed ones?
I would suggest to wait until you get input on all the patches before
respinning.
Cheers,
--
Julien Grall
