On 22.06.2022 14:35, Michal Orzel wrote:
> Hi Anthony,
>
> On 21.06.2022 12:11, Anthony PERARD wrote:
>> The command line generated for headers++.chk by make is quite long,
>> and in some environment it is too long. This issue have been seen in
>> Yocto build environment.
>>
>> Error messages:
>> make[9]: execvp: /bin/sh: Argument list too long
>> make[9]: *** [include/Makefile:181: include/headers++.chk] Error 127
>>
>> Rework so that we do the foreach loop in shell rather that make to
>> reduce the command line size by a lot. We also need a way to get
>> headers prerequisite for some public headers so we use a switch "case"
>> in shell to be able to do some simple pattern matching. Variables
>> alone in POSIX shell don't allow to work with associative array or
>> variables with "/".
>>
>> Also rework headers99.chk as it has a similar implementation, even if
>> with only two headers to check the command line isn't too long at the
>> moment.
>>
>> Reported-by: Bertrand Marquis <bertrand.marq...@arm.com>
>> Fixes: 28e13c7f43 ("build: xen/include: use if_changed")
>> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
>> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
>
> Reviewed-by: Michal Orzel <michal.or...@arm.com>
Acked-by: Jan Beulich <jbeul...@suse.com>
> Tested-by: Michal Orzel <michal.or...@arm.com>
>
> Cheers,
> Michal
