> On 9 Dec 2021, at 11:27, Jan Beulich <[email protected]> wrote: > > For guests in shadow mode the P2M table gets used only by software. The > only place where it matters whether superpages in the P2M can be dealt > with is sh_unshadow_for_p2m_change().
It’s easy to verify that this patch is doing what it claims to do; but whether
it’s correct or not depends on the veracity of this claim here. Rather than me
having to duplicate whatever work you did to come to this conclusion, can you
briefly explain why it’s true in a way that I can easily verify?
e.g., all other accesses to the p2m in the shadow code are via
get_gfn_[something](), which (because it’s in the p2m code) handles p2m
superpages correctly?
Everything else looks good here.
> That function has been capabale of
> handling them even before commit 0ca1669871f8a ("P2M: check whether hap
> mode is enabled before using 2mb pages") disabled 2M use in this case
> for dubious reasons ("potential errors when hap is disabled").
I’m glad the days of random patches being checked in without comment or
discussion are behind us...
-George
signature.asc
Description: Message signed with OpenPGP
