On 11.07.2022 10:30, Demi Marie Obenour wrote: > On Mon, Jul 11, 2022 at 08:41:59AM +0200, Jan Beulich wrote: >> On 08.07.2022 23:34, Demi Marie Obenour wrote: >>> @@ -1051,6 +1110,70 @@ static void __init >>> efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop >>> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ >>> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) >>> >>> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) >>> +{ >>> + EFI_STATUS status; >>> + UINTN info_size = 0, map_key, mdesc_size; >>> + void *memory_map = NULL; >>> + UINT32 ver; >>> + unsigned int i; >>> + >>> + for ( ; ; ) { >> >> I'm sorry, but I'm now going to be picky and _not_ offer correcting >> this style violation for you anymore. > > No apology needed. Is the problem that the brace should be on a > separate line, that the spaces around the semicolons should be removed, > or both?
The former. Iirc you did actually _add_ the spaces upon my request. Jan