On 14.07.2022 12:33, Andrew Cooper wrote: > On 14/07/2022 11:12, Luca Fancellu wrote: >> + CC x86 maintainers >> >>> On 14 Jul 2022, at 10:40, Mathieu Tarral <mathieu.tar...@protonmail.com> >>> wrote: >>> >>> Hi Luca, >>> >>>> Hi Mathieu, >>>> >>>> You are missing wget in your packages. >>> Indeed, installing wget solved the issue and I was able to generate >>> a debian package. >>> >>> Still, we have a build system that silently depends on gawk and wget, and >>> there is no check in the configure script to ensure these tools are >>> installed. >>> >>> And the errors in the build system are quite obscure, it's hard to >>> understand that you were missing gawk or wget in the first place. >>> >>> What do you think about this ? >> Hi Mathieu, >> >> I’ve CC the x86 maintainer, probably they know better the reasons. > > These are two different problems. > > The configure script does check for WGET (or more generally FETCHER) and > will object if something is not present. This is only relevant for > tools/ which you should have been forced to run configure for anyway, so > I'm really not sure what went on there. > > For valid-addrs vs all-addrs, that's come up on xen-devel before. I > think the general consensus is that we don't want to silently depend on > gawk. > > (We're trying some new project management tools.) Can you try opening a > bug here: https://gitlab.com/xen-project/xen/-/issues about the > check-endbr.sh issue? > > This ought to be a 4.17 release blocker seeing as its a regression from > 4.16. (CC'ing Henry as release manager.)
Except that 4.16 and older then already have regressed as well, due to the backports they've received. Jan
