> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.per...@citrix.com> wrote:
>
> Remove "build" targets.
>
> Use simply expanded variables when recursively expanded variable
> aren't needed. (Use ":=" instead of "=".)
>
> Don't check if a directory already exist when installing, just create
> it.
>
> Fix $(HOTPLUGPATH), it shouldn't have any double-quote.
>
> Some reindentation.
>
> FreeBSD, "hotplugpath.sh" is already installed by common/.
>
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
Hi Antony,
> ---
> tools/hotplug/FreeBSD/Makefile | 11 +++--------
> tools/hotplug/Linux/Makefile | 16 ++++++----------
> tools/hotplug/Linux/systemd/Makefile | 16 +++++++---------
> tools/hotplug/NetBSD/Makefile | 9 +++------
> tools/hotplug/common/Makefile | 16 ++++++----------
> 5 files changed, 25 insertions(+), 43 deletions(-)
>
> diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makefile
> index de9928cd86..a6552c9884 100644
> --- a/tools/hotplug/FreeBSD/Makefile
> +++ b/tools/hotplug/FreeBSD/Makefile
> @@ -2,18 +2,15 @@ XEN_ROOT = $(CURDIR)/../../..
> include $(XEN_ROOT)/tools/Rules.mk
>
> # Xen script dir and scripts to go there.
> -XEN_SCRIPTS = vif-bridge block
> +XEN_SCRIPTS := vif-bridge block
>
> -XEN_SCRIPT_DATA =
> +XEN_SCRIPT_DATA :=
Here (and also in NetBSD) the variable is empty, why are we keeping them
and the related code? Is it to keep a certain structure?
However the changes works and looks good to me, so your choice if it needs
to be addressed or not
Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
