On 03.08.2022 12:57, Anthony PERARD wrote: > On Wed, Aug 03, 2022 at 10:24:26AM +0000, Edwin Torok wrote: >> >> -ifneq ($(MAKECMDGOALS),clean) >> +ifeq (,$(findstring clean,$(MAKECMDGOALS))) > > I think it would be better with $(filter-out,): > > ifeq (,$(filter-out %clean,$(MAKECMDGOALS))) > >> .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile >> $(OCAML_TOPLEVEL)/Makefile.rules >> $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli >> $o,MLDEP,) > > Also, don't hide this rule, instead, hide the "-include", there is no > need to have make waist time trying to find a rule to make > ".ocamldep.make" and failing when not needed.
Hmm, this sounds like I should be reverting the commit? Jan
