On Fri, Aug 12, 2022 at 03:36:12PM +0200, Jan Beulich wrote:
> On 11.08.2022 18:48, Anthony PERARD wrote:
> > Setup proper dependencies with libacpi so we don't need to run "make
> > hvmloader" in the "all" target. ("build.o" new prerequisite isn't
> > exactly proper but a side effect of building the $(DSDT_FILES) is to
> > generate the "ssdt_*.h" needed by "build.o".)
> >
> > Make use if "-iquote" instead of a plain "-I".
> >
> > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use
> > full path to "mkhex" instead of a relative one. Lastly, add "-f" flag
> > to "mv" to avoid a prompt in case the target already exist and we
> > don't have write permission.
> >
> > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
> > Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
>
> Reviewed-by: Jan Beulich <jbeul...@suse.com>
> with one nit (which I'd be happy to take care of while committing):
>
> > @@ -73,12 +72,18 @@ smbios.o: CFLAGS +=
> > -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\""
> > ACPI_PATH = ../../libacpi
> > DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c
> > ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES)) build.o static_tables.o
> > -$(ACPI_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
> > +$(ACPI_OBJS): CFLAGS += -iquote . -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\"
> > CFLAGS += -I$(ACPI_PATH)
> > vpath build.c $(ACPI_PATH)
> > vpath static_tables.c $(ACPI_PATH)
> > OBJS += $(ACPI_OBJS)
> >
> > +$(DSDT_FILES): acpi
> > +
> > +# Add DSDT_FILES as a prerequisite of "build.o" so that make will also
> > +# generates the "ssdt_*.h" headers needed by "build.o".
>
> s/generates/generate/ ?
Yes, thanks.
--
Anthony PERARD
