On Fri, Sep 16, 2022 at 01:20:11AM +0100, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [PATCH] libvirt: disable Werror for non-libvirt
> flights"):
> > I don't mind using -Dwerror=false if that's considered better. Ian, do
> > you have an opinion?
>
> No, I don't think I do. I think it depends on what kinds of things
> are likely to change, or go wrong, in libvirt.
>
> - *) libvirt_build_runvars+=" make_njobs=1";;
> + *) libvirt_build_runvars+=" make_njobs=1
> meson_options=-Dwerror=false autogen_options=--disable-werror";;
>
> I wonder if it would be better to abstract this away and instead have
> a runvar like "libvrit_build_werror=false". But maybe that is
> gold-plating it.
Did consider this initially, but decided to use specific options for
mesa/autogen in case we need to add further switches to specific
configuration systems (unlikely I guess, because autogen won't be used
anymore).
> If you choose to keep that the way it is, then for either version of
> this patch:
>
> Acked-by: Ian Jackson <[email protected]>
Thanks, Roger.
