Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

[Luca Fancellu]

> On 26 Sep 2022, at 12:04, Michal Orzel <michal.or...@amd.com> wrote:
> 
> Take an example from arm64 qemu test scripts and use ImageBuilder
> to generate u-boot script automatically. Calculating the addresses
> manually is quite error prone and also we will be able to benefit
> from using ImageBuilder when adding domUs to this test in the future.
> 
> Install and use u-boot from the debian package.
> Modify the script so that binaries are loaded from u-boot via tftp.
> Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always
> set to pl011 node path.
> 
> Signed-off-by: Michal Orzel <michal.or...@amd.com>
> ---
> Changes in v2:
> - add explanation in commit msg why we remove dtuart path
> ---

Hi Michal,

This looks good to me

Reviewed-by: Luca Fancellu <luca.fance...@arm.com>